implicit-casts:false in flutter/lib/src/semantics#45722
Merged
a14n merged 1 commit intoflutter:masterfrom Dec 4, 2019
Merged
Conversation
fluttergithubbot
added
a: accessibility
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
a14n
force-pushed
the
implicit-casts-false-flutter-lib-semantics
branch
from
5381f77 to
f6f75f2
Compare
goderbauer
reviewed
Dec 2, 2019
| return typedOther.label == label | ||
| && typedOther.hint == hint | ||
| && typedOther.action == action; | ||
| return other is CustomSemanticsAction |
Member
There was a problem hiding this comment.
Same as in the other PRs, we already know that other is assignable to CustomSemanticsAction.
| final SemanticsHintOverrides typedOther = other; | ||
| return typedOther.onTapHint == onTapHint | ||
| && typedOther.onLongPressHint == onLongPressHint; | ||
| return other is SemanticsHintOverrides |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable
implicit-casts:falseinflutter/lib/src/semanticsRelated Issues
None
Tests
None because it's a refactoring.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?