Simplify logging code in flutter_driver#45945
Merged
Hixie merged 2 commits intoflutter:masterfrom Dec 4, 2019
Merged
Conversation
fluttergithubbot
added
a: tests
yjbanov
approved these changes
Dec 3, 2019
Contributor
yjbanov
left a comment
yjbanov
left a comment
There was a problem hiding this comment.
LGTM, but heads up, this is a breaking change.
Contributor
There was a problem hiding this comment.
A lot of these messages would be just noise for most normal usages of flutter driver, but since we seem to be printing everything all the time anyway, then sure 🤷♂
Contributor
Author
There was a problem hiding this comment.
I audited them all and they seemed pretty reasonable.
Contributor
Author
|
Our breaking change policy has changed, this isn't a breaking change according to the new definitions. |
It appears nobody is benefitting from this logic, so we may as well not pay the cost.
This is the second attempt at this; it should be better than before because the Logger interface, which conflicted in various places, no longer exists. See flutter#45733 for original attempt. This reverts commit 0ce9206 (PR flutter#45924).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears nobody is benefitting from this logic, so we may as well not pay the cost.
cc @yjbanov