[Driver] correction of data returned by getWidgetDiagnostics#45985
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Dec 4, 2019
Merged
Conversation
jacek-marchwicki
commented
Dec 3, 2019
| }) async { | ||
| return _sendCommand(GetDiagnosticsTree( | ||
| finder, | ||
| DiagnosticsType.renderObject, |
Contributor
Author
There was a problem hiding this comment.
note: you can see that this was exactly the same implementation as getRenderObjectDiagnostics:
Future<Map<String, Object>> getRenderObjectDiagnostics(
SerializableFinder finder, {
int subtreeDepth = 0,
bool includeProperties = true,
Duration timeout,
}) async {
return _sendCommand(GetDiagnosticsTree(
finder,
DiagnosticsType.renderObject,
subtreeDepth: subtreeDepth,
includeProperties: includeProperties,
timeout: timeout,
));
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously
getWidgetDiagnosticswere returning a render object diagnostics instead of the widget diagnostics.The method has been returning the same data as
getRenderObjectDiagnostics.This is my first contribution to the project, so please forgive me If I do something incorrectly.
Related Issues
No issues related.
Related change: #34440
Tests
The code wasn't covered by tests, so added
sends the getWidgetDiagnostics commandandsends the getRenderObjectDiagnostics commandtests.Checklist
///). No new features(cd packages/flutter_driver && ../../bin/flutter test))flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?
It's hard to say if this is a breaking change. Actually, the method has been returning incorrect results. So the results of using the method in tests are different now.