Dispatch hover events to PlatformViewController#46124
Merged
cbracken merged 1 commit intoflutter:masterfrom Dec 5, 2019
Merged
Dispatch hover events to PlatformViewController#46124cbracken merged 1 commit intoflutter:masterfrom
cbracken merged 1 commit intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
framework
dkwingsmt
approved these changes
Dec 5, 2019
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM, with suggestion on docs
This adds support to PlatformViewLayer for handling hover events. Prior to this, PlatformViewLayers only supported events forwarded by the gesture recognizers associated with the PlatformViewRenderBox. Hover events don't participate in gesture recognition and as such are dropped in GestureBinding. That said, hover event processing in platform views is expected for desktop and other platforms with hover event support. This adds support for passing an optional MouseTrackerAnnotation to PlatformViewLayer. PlatformViewRenderBox populates this with a mouse tracker annotation that forwards hover events to PlatformViewController.dispatchPointerEvent() for handling by users.
cbracken
force-pushed
the
platformlayer-hover
branch
from
6da9a30 to
f6d9b48
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to PlatformViewLayer for handling hover events. Prior to this, PlatformViewLayers only supported events forwarded by the gesture recognizers associated with the PlatformViewRenderBox. Hover events don't participate in gesture recognition and as such are dropped in GestureBinding. That said, hover event processing in platform views is expected for desktop and other platforms with hover event support.
This adds support for passing an optional MouseTrackerAnnotation to PlatformViewLayer. PlatformViewRenderBox populates this with a mouse tracker annotation that forwards hover events to PlatformViewController.dispatchPointerEvent() for handling by users.