Skip to content

Exclude modal barrier Semantics in Drawer on Android#48841

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
perclasson:dismissing_drawer_android
Jan 16, 2020
Merged

Exclude modal barrier Semantics in Drawer on Android#48841
fluttergithubbot merged 1 commit intoflutter:masterfrom
perclasson:dismissing_drawer_android

Conversation

@perclasson
Copy link
Copy Markdown
Contributor

@perclasson perclasson commented Jan 14, 2020

Description

Right now the semantics of the modal barrier for Drawer is visible and accessible for Android even though that is not intended behavior. The way to close the Drawer is via the back button. This change makes sure the dismiss semantics barrier does not show up on Android.

Related Issues

Fixes #39896

Tests

I added the following tests:

"Dismissible ModalBarrier includes button in semantic tree on iOS" test/widgets/drawer_test.dart

"Dismissible ModalBarrier is hidden on Android (back button is used to dismiss)" test/widgets/drawer_test.dart

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 14, 2020
Comment thread packages/flutter/lib/src/material/drawer.dart Outdated
Comment thread packages/flutter/test/widgets/drawer_test.dart Outdated
@perclasson perclasson force-pushed the dismissing_drawer_android branch from 2ec5808 to cb14d2f Compare January 14, 2020 22:14
@perclasson perclasson requested a review from HansMuller January 14, 2020 22:30
Copy link
Copy Markdown
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit a752435 into flutter:master Jan 16, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dismissing drawer tapping the black overlay calls onTap on ListTile if Talkback is on

5 participants