replace runtimeType.toString()

[a14n]

Description

follow up on #48607

Related Issues

#31695

Tests

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I signed the CLA.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I updated/added relevant documentation (doc comments with ///).
• All existing and new tests are passing.
• The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

• No, no existing tests failed, so this is not a breaking change.

[fluttergithubbot]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[a14n]

I made a lint available in https://github.com/a14n/linter/tree/avoid_runtimeType_toString that find some other places but I'm not sure if it make sense to replace them. WDYT?

$ bin/cache/dart-sdk/bin/dart ../../dart-lang/linter/bin/linter.dart --rules avoid_runtimeType_toString --packages packages/flutter/.packages packages/flutter/lib | grep 'lint'
/xxx/packages/flutter/lib/src/animation/listener_helpers.dart 130:69 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/animation/listener_helpers.dart 133:21 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/animation/listener_helpers.dart 199:76 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/animation/listener_helpers.dart 202:21 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/foundation/change_notifier.dart 212:77 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/foundation/change_notifier.dart 215:23 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/foundation/diagnostics.dart 1544:15 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/rendering/debug_overflow_indicator.dart 206:27 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/rendering/debug_overflow_indicator.dart 209:19 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/rendering/debug_overflow_indicator.dart 215:36 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/rendering/debug_overflow_indicator.dart 244:37 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/rendering/debug_overflow_indicator.dart 252:49 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/widgets/framework.dart 1519:38 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/widgets/framework.dart 1520:20 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/widgets/framework.dart 1524:25 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/widgets/focus_manager.dart 1301:75 [lint] Avoid calling toString() on runtimeType.
/xxx/packages/flutter/lib/src/widgets/focus_manager.dart 1304:21 [lint] Avoid calling toString() on runtimeType.

[dnfield]

This one is ok because it's part of an assertion.

Is there some way to make the lint recognize whether the call is within an assert or throw?

[a14n]

The lint does test if it's inside an assertion. I don't see assert in this case.

[dnfield]

Ah yes, I was imprecise. It should still be ok if it's part of a throw. At that point, we don't really care about performance as much anymore and having the real type information would be helpful.

[a14n]

I reverted this change.

[dnfield]

LGTM, thanks!