Skip to content

Grammar fix: "it's" -> "its"#48913

Merged
fluttergithubbot merged 2 commits intomasterfrom
DaveShuckerow-patch-1
Jan 22, 2020
Merged

Grammar fix: "it's" -> "its"#48913
fluttergithubbot merged 2 commits intomasterfrom
DaveShuckerow-patch-1

Conversation

@DaveShuckerow
Copy link
Copy Markdown
Contributor

@DaveShuckerow DaveShuckerow commented Jan 15, 2020

Description

Fixing docs

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 15, 2020
Copy link
Copy Markdown
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Copy Markdown
Member

Tests are obviously not needed for this change. You can ignore the bot message :)

@DaveShuckerow
Copy link
Copy Markdown
Contributor Author

Tests are obviously not needed for this change. You can ignore the bot message :)

I feel like this is going to put me on a naughty list somewhere... 😮

😃

@goderbauer
Copy link
Copy Markdown
Member

Hey @DaveShuckerow,

I know this is annoying, but it looks like Cirrus got the hick-ups on this PR. It aborted all runs without properly reporting status back to github. I don't see a "re-run all" button on Cirrus anymore. Rather then restarting each shard individually, I believe the quickest way to re-run all tests would be for you to push a new (empty) commit. Any change you could do that?

Sorry for the inconvenience.

@fluttergithubbot fluttergithubbot merged commit 4c32ae8 into master Jan 22, 2020
@dnfield dnfield deleted the DaveShuckerow-patch-1 branch February 17, 2020 22:31
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants