Skip to content

Update assert message for AnimatedContainer#48962

Merged
goderbauer merged 1 commit intoflutter:masterfrom
suragch:patch-1
Jan 16, 2020
Merged

Update assert message for AnimatedContainer#48962
goderbauer merged 1 commit intoflutter:masterfrom
suragch:patch-1

Conversation

@suragch
Copy link
Copy Markdown
Contributor

@suragch suragch commented Jan 16, 2020

Description

The error message was misleading because BoxDecoration does not have a backgroundColor parameter. Instead it has a color parameter, which sets the background color. I also removed the optional new keyword.

The error message was misleading because BoxDecoration does not have a `backgroundColor` parameter. Instead it has a `color` parameter, which sets the background color. I also removed the optional `new` keyword.
@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 16, 2020
Copy link
Copy Markdown
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@goderbauer goderbauer merged commit 4c1d79f into flutter:master Jan 16, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants