Skip to content

Fix template syntax error in WidgetController doc#49255

Merged
fluttergithubbot merged 1 commit intomasterfrom
fix-widget-controller-doc
Jan 22, 2020
Merged

Fix template syntax error in WidgetController doc#49255
fluttergithubbot merged 1 commit intomasterfrom
fix-widget-controller-doc

Conversation

@dkwingsmt
Copy link
Copy Markdown
Contributor

@dkwingsmt dkwingsmt commented Jan 21, 2020

Description

This PR fixes the a template syntax error in the doc of WidgetController that results in missing reference.

image

Related Issues

  • N/A

Tests

I added the following tests:

  • N/A, it's a doc fix

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jan 21, 2020
@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Copy Markdown
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit d3a835e into master Jan 22, 2020
@dnfield dnfield deleted the fix-widget-controller-doc branch February 17, 2020 22:31
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants