Skip to content

Script to generate missing localization resources#49379

Merged
darrenaustin merged 2 commits intoflutter:masterfrom
darrenaustin:gen_missing_localizations
Jan 28, 2020
Merged

Script to generate missing localization resources#49379
darrenaustin merged 2 commits intoflutter:masterfrom
darrenaustin:gen_missing_localizations

Conversation

@darrenaustin
Copy link
Copy Markdown
Contributor

Description

This PR adds a new script that updates the language locale arb files with any missing resource entries that are included in the english arb files. This is useful when adding new resources for localization. You can just add the appropriate entries to the english arb file and then run this script. It will then check all of the other language locale arb files and update them with new 'TBD' entries for any missing resources. These will be picked up by the localization team and then translated.

Usage

Run this program from the root of the git repository.

dart dev/tools/localization/bin/gen_missing_localizations.dart

See lib/src/material/material_localizations.dart for more info on the process to add new localizations for the Flutter framework.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jan 23, 2020
Comment thread dev/tools/localization/bin/gen_missing_localizations.dart Outdated
Comment thread dev/tools/localization/bin/gen_missing_localizations.dart Outdated
Comment thread dev/tools/localization/bin/gen_missing_localizations.dart Outdated
Comment thread dev/tools/localization/bin/gen_missing_localizations.dart Outdated
Comment thread dev/tools/localization/bin/gen_missing_localizations.dart Outdated
Copy link
Copy Markdown
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot
Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Cirrus CI has failed. Please fix the issues identified (or deflake) before re-applying this label.

@darrenaustin darrenaustin merged commit 9980d6e into flutter:master Jan 28, 2020
@darrenaustin darrenaustin deleted the gen_missing_localizations branch January 28, 2020 01:51
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants