Fix StrutStyle docs to remove references to leading property.#49443
Merged
Fix StrutStyle docs to remove references to leading property.#49443
Conversation
fluttergithubbot
added
the
framework
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Piinks
added
waiting for tree to go green
d: api docs
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Piinks
reviewed
Jan 27, 2020
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
I've re-run the add-to-app test. Should be able to merge this time. 😝
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
Author
|
Landing. Docs only change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only change
The
leadingproperty was removed, so these references to it are outdated.Also added a note to help reduce confusion when people see that most fonts have zero leading.