Skip to content

Run "build ios-framework" processes async#49657

Merged
jmagman merged 2 commits intoflutter:masterfrom
jmagman:xcode-build-fw
Feb 4, 2020
Merged

Run "build ios-framework" processes async#49657
jmagman merged 2 commits intoflutter:masterfrom
jmagman:xcode-build-fw

Conversation

@jmagman
Copy link
Copy Markdown
Member

@jmagman jmagman commented Jan 29, 2020

Description

Run lipo and xcodebuild processes async since they can take a few seconds and were causing status waiting indicator stutter.

Tests

Already exercised in build_ios_framework_module_test.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. a: existing-apps Integration with existing apps via the add-to-app flow labels Jan 29, 2020
@jmagman jmagman requested a review from zanderso January 29, 2020 00:26
@jmagman jmagman self-assigned this Jan 29, 2020
@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Comment thread packages/flutter_tools/lib/src/commands/build_ios_framework.dart Outdated
Comment thread packages/flutter_tools/lib/src/commands/build_ios_framework.dart Outdated
@jmagman jmagman merged commit 6e605f3 into flutter:master Feb 4, 2020
@jmagman jmagman deleted the xcode-build-fw branch February 4, 2020 22:17
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: existing-apps Integration with existing apps via the add-to-app flow platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants