Remove unnecessary BuildableIOSApp from "build ios-framework"#49659
Merged
jmagman merged 2 commits intoflutter:masterfrom Jan 29, 2020
Merged
Remove unnecessary BuildableIOSApp from "build ios-framework"#49659jmagman merged 2 commits intoflutter:masterfrom
jmagman merged 2 commits intoflutter:masterfrom
Conversation
jmagman
added
tool
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
|
||
| if (iosProject == null) { | ||
| throwToolExit("Module's iOS folder missing"); | ||
| if (_project.ios.existsSync() == null) { |
Contributor
There was a problem hiding this comment.
shouldn't this be if (!_project.existsSync()) {?
Member
Author
There was a problem hiding this comment.
It's to check that the project even has an iOS directory. It already checked that the pubspec exists at this point.
Contributor
There was a problem hiding this comment.
yeah, my suggestion had a typo...but you know what i mean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Already have a
FlutterProjectinstance, use it instead of creating aBuildableIOSApp.Tests
Already exercised in build_ios_framework_module_test.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change