Skip to content

SimpleDialogOption: support custom padding#50035

Merged
fluttergithubbot merged 10 commits intoflutter:masterfrom
arthurdenner:feat/simpledialogaction-support-custom-padding
Feb 12, 2020
Merged

SimpleDialogOption: support custom padding#50035
fluttergithubbot merged 10 commits intoflutter:masterfrom
arthurdenner:feat/simpledialogaction-support-custom-padding

Conversation

@arthurdenner
Copy link
Copy Markdown
Contributor

@arthurdenner arthurdenner commented Feb 3, 2020

Description

This PR adds support for a custom padding property on SimpleDialogOption. After running the Accessibility Scanner on one of my apps, I was pointed that the height of the options should be bigger, but there is no current support for that and I extended the SimpleDialogOption class to add it. Now, I'm proposing this change to be added on Flutter itself.

Related Issues

I couldn't find any.

Tests

I added the following tests:

  • Custom padding on SimpleDialogOption

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 3, 2020
Comment thread packages/flutter/test/material/dialog_test.dart Outdated
Comment thread packages/flutter/test/material/dialog_test.dart Outdated
Comment thread packages/flutter/test/material/dialog_test.dart Outdated
Comment thread packages/flutter/lib/src/material/dialog.dart Outdated
Comment thread packages/flutter/test/material/dialog_test.dart Outdated
@shihaohong
Copy link
Copy Markdown
Contributor

Also, it seems like the flutter analyzer is failing on trailing whitespace. Also, unrelated presubmit checks are failing to you might have to rebase with upstream/master

@arthurdenner arthurdenner force-pushed the feat/simpledialogaction-support-custom-padding branch from 9b1325e to 5ebf984 Compare February 11, 2020 22:20
Comment thread packages/flutter/test/material/dialog_test.dart
Copy link
Copy Markdown
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus the typo in the API doc

Comment thread packages/flutter/test/material/dialog_test.dart
Comment thread packages/flutter/lib/src/material/dialog.dart Outdated
Comment thread packages/flutter/lib/src/material/dialog.dart
@shihaohong
Copy link
Copy Markdown
Contributor

Thank you for your contribution, it has just been merged :)

@arthurdenner arthurdenner deleted the feat/simpledialogaction-support-custom-padding branch February 12, 2020 22:52
@arthurdenner
Copy link
Copy Markdown
Contributor Author

Thank you for the reviews and interactions here, @shihaohong!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants