SimpleDialogOption: support custom padding#50035
Merged
fluttergithubbot merged 10 commits intoflutter:masterfrom Feb 12, 2020
Merged
SimpleDialogOption: support custom padding#50035fluttergithubbot merged 10 commits intoflutter:masterfrom
fluttergithubbot merged 10 commits intoflutter:masterfrom
Conversation
shihaohong
reviewed
Feb 6, 2020
shihaohong
reviewed
Feb 11, 2020
Contributor
|
Also, it seems like the flutter analyzer is failing on trailing whitespace. Also, unrelated presubmit checks are failing to you might have to rebase with |
9b1325e to
5ebf984
Compare
arthurdenner
commented
Feb 11, 2020
shihaohong
approved these changes
Feb 11, 2020
Contributor
shihaohong
left a comment
There was a problem hiding this comment.
LGTM, minus the typo in the API doc
shihaohong
reviewed
Feb 11, 2020
Co-Authored-By: Shi-Hao Hong <shihaohong@google.com>
Contributor
|
Thank you for your contribution, it has just been merged :) |
Contributor
Author
|
Thank you for the reviews and interactions here, @shihaohong! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for a custom
paddingproperty onSimpleDialogOption. After running the Accessibility Scanner on one of my apps, I was pointed that the height of the options should be bigger, but there is no current support for that and I extended theSimpleDialogOptionclass to add it. Now, I'm proposing this change to be added on Flutter itself.Related Issues
I couldn't find any.
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.