Skip to content

WIP Revert "Fixing constraints.precedingScrollExtent passed to SliverPadding child"#50210

Closed
Piinks wants to merge 1 commit intomasterfrom
revert-49433-precedePadding
Closed

WIP Revert "Fixing constraints.precedingScrollExtent passed to SliverPadding child"#50210
Piinks wants to merge 1 commit intomasterfrom
revert-49433-precedePadding

Conversation

@Piinks
Copy link
Copy Markdown
Contributor

@Piinks Piinks commented Feb 5, 2020

Reverts #49433

This is breaking tests in the roll. :(

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 5, 2020
@Piinks Piinks added the f: scrolling Viewports, list views, slivers, etc. label Feb 5, 2020
Copy link
Copy Markdown
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks
Copy link
Copy Markdown
Contributor Author

Piinks commented Feb 5, 2020

This may not need to be reverted. Will update.

@Piinks Piinks changed the title Revert "Fixing constraints.precedingScrollExtent passed to SliverPadding child" WIP Revert "Fixing constraints.precedingScrollExtent passed to SliverPadding child" Feb 5, 2020
@Piinks
Copy link
Copy Markdown
Contributor Author

Piinks commented Feb 5, 2020

It looks like this will not need to be reverted.

@Piinks Piinks closed this Feb 5, 2020
@dnfield dnfield deleted the revert-49433-precedePadding branch February 8, 2020 05:32
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants