Skip to content

[gen_l10n] Remove redundant tests#50301

Merged
shihaohong merged 3 commits intoflutter:masterfrom
shihaohong:l10n-remove-redundant-tests
Feb 7, 2020
Merged

[gen_l10n] Remove redundant tests#50301
shihaohong merged 3 commits intoflutter:masterfrom
shihaohong:l10n-remove-redundant-tests

Conversation

@shihaohong
Copy link
Copy Markdown
Contributor

Description

Since integration tests were introduced for gen_l10n, some of the unit tests are redundant since the new integration test better tests the correct behavior. This PR simply removes the redundant testing.

Related Issues

n/a

Tests

I added the following tests:

  • Redundant tests were removed in this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@shihaohong shihaohong requested a review from HansMuller February 6, 2020 22:07
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 6, 2020
@shihaohong shihaohong added the a: internationalization Supporting other languages or locales. (aka i18n) label Feb 6, 2020
Copy link
Copy Markdown
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should land another PR that simplifies (refactors) the remaining tests so that the code is easier to read.

});

group('Setters', () {
test('happy path', () {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is viewed as redundant because the integration tests rely on being able to write to their "happy path" :-).

@shihaohong shihaohong changed the title [l10n] Remove redundant tests [gen_l10n] Remove redundant tests Feb 7, 2020
@shihaohong shihaohong merged commit 5dfa8e9 into flutter:master Feb 7, 2020
@shihaohong shihaohong deleted the l10n-remove-redundant-tests branch February 7, 2020 21:59
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: internationalization Supporting other languages or locales. (aka i18n) c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants