[gen_l10n] Remove redundant tests#50301
Merged
shihaohong merged 3 commits intoflutter:masterfrom Feb 7, 2020
shihaohong:l10n-remove-redundant-tests
Merged
[gen_l10n] Remove redundant tests#50301shihaohong merged 3 commits intoflutter:masterfrom shihaohong:l10n-remove-redundant-tests
shihaohong merged 3 commits intoflutter:masterfrom
shihaohong:l10n-remove-redundant-tests
Conversation
HansMuller
approved these changes
Feb 6, 2020
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
We should land another PR that simplifies (refactors) the remaining tests so that the code is easier to read.
| }); | ||
|
|
||
| group('Setters', () { | ||
| test('happy path', () { |
Contributor
There was a problem hiding this comment.
I assume this is viewed as redundant because the integration tests rely on being able to write to their "happy path" :-).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since integration tests were introduced for gen_l10n, some of the unit tests are redundant since the new integration test better tests the correct behavior. This PR simply removes the redundant testing.
Related Issues
n/a
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.