Remove some obsolete // ignore:#50481
Merged
goderbauer merged 1 commit intoflutter:masterfrom Feb 10, 2020
Merged
Conversation
9 tasks
Contributor
|
Although cirrus seems to be unhappy right now. Looks to be timeouts. |
Member
Author
|
Restarted all the cirrus checks that timed out. |
Contributor
|
This would be a good one to land on red to kick CI. We've disabled some fuchsia tests that are flaky right now. That should be rolled through in a few minutes. |
Member
Author
|
@dnfield Feel free to submit this whenever the roll is done. |
Member
Author
|
Submitting on red per @dnfield's comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These were no longer ignoring any warnings. They have been identified as obsolete by @srawlins in #45855.
Related Issues
None
Tests
I added the following tests:
None, comment only change.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.