Skip to content

Remove some obsolete // ignore:#50481

Merged
goderbauer merged 1 commit intoflutter:masterfrom
goderbauer:removeObsoleteIgonrs
Feb 10, 2020
Merged

Remove some obsolete // ignore:#50481
goderbauer merged 1 commit intoflutter:masterfrom
goderbauer:removeObsoleteIgonrs

Conversation

@goderbauer
Copy link
Copy Markdown
Member

Description

These were no longer ignoring any warnings. They have been identified as obsolete by @srawlins in #45855.

Related Issues

None

Tests

I added the following tests:

None, comment only change.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 10, 2020
@goderbauer goderbauer mentioned this pull request Feb 10, 2020
9 tasks
Copy link
Copy Markdown
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks
Copy link
Copy Markdown
Contributor

Piinks commented Feb 10, 2020

Although cirrus seems to be unhappy right now. Looks to be timeouts.

@goderbauer
Copy link
Copy Markdown
Member Author

Restarted all the cirrus checks that timed out.

@dnfield
Copy link
Copy Markdown
Contributor

dnfield commented Feb 10, 2020

This would be a good one to land on red to kick CI. We've disabled some fuchsia tests that are flaky right now. That should be rolled through in a few minutes.

@goderbauer
Copy link
Copy Markdown
Member Author

@dnfield Feel free to submit this whenever the roll is done.

@goderbauer
Copy link
Copy Markdown
Member Author

Submitting on red per @dnfield's comment.

@goderbauer goderbauer merged commit 6d87337 into flutter:master Feb 10, 2020
@goderbauer goderbauer deleted the removeObsoleteIgonrs branch February 10, 2020 22:08
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants