Skip to content

Update Android activities because plugin registration is now done by FlutterActivity.configureFlutterEngine#50841

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
jason-simmons:configure_engine_super
Feb 28, 2020
Merged

Update Android activities because plugin registration is now done by FlutterActivity.configureFlutterEngine#50841
fluttergithubbot merged 1 commit intoflutter:masterfrom
jason-simmons:configure_engine_super

Conversation

@jason-simmons
Copy link
Copy Markdown
Member

@jason-simmons jason-simmons commented Feb 15, 2020

See #49365

@fluttergithubbot fluttergithubbot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 15, 2020
@jason-simmons jason-simmons requested a review from mklim February 15, 2020 00:14
xster
xster approved these changes Feb 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread ...s/templates/app/android-java.tmpl/app/src/main/java/androidIdentifier/MainActivity.java.tmpl Outdated
Copy link
Copy Markdown
Member

@xster xster Feb 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want bonus points, we can actually toggle the AndroidManifest to straight up point the activity to io.flutter.embedding.android.FlutterActivity :) but that probably takes a few more tooling changes

Copy link
Copy Markdown
Contributor

@mklim mklim Feb 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought this up with I think @blasten earlier. He mentioned that it would be relatively difficult to change to tool to just never generate a file like this based on the embedding flag. I think it's okay to generate an empty MainActivity, it provides an easy entry point for anyone who wants to customize it.

Copy link
Copy Markdown
Member

@xster xster Feb 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that was the piece I was missing, whether the tool makes it hard to toggle. This LG then.

blasten
blasten approved these changes Feb 15, 2020
View reviewed changes
Copy link
Copy Markdown

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mklim
mklim reviewed Feb 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mklim mklim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LG, thanks! Can this be tested at all?

Comment thread ...s/templates/app/android-java.tmpl/app/src/main/java/androidIdentifier/MainActivity.java.tmpl Outdated
Copy link
Copy Markdown
Contributor

@mklim mklim Feb 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought this up with I think @blasten earlier. He mentioned that it would be relatively difficult to change to tool to just never generate a file like this based on the embedding flag. I think it's okay to generate an empty MainActivity, it provides an easy entry point for anyone who wants to customize it.

@fluttergithubbot fluttergithubbot merged commit d499d61 into flutter:master Feb 28, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster xster approved these changes

+2 more reviewers

@mklim mklim mklim left review comments

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jason-simmons @xster @blasten @mklim @jmagman @googlebot @fluttergithubbot