Removed the unecessary "new" keyword from the docs#51075
Merged
goderbauer merged 3 commits intoflutter:masterfrom Feb 24, 2020
Merged
Removed the unecessary "new" keyword from the docs#51075goderbauer merged 3 commits intoflutter:masterfrom
goderbauer merged 3 commits intoflutter:masterfrom
Conversation
As the new Dart versions allow us to omit the `new` keyword on constructors and most docs and examples follow this, I think its reasonable to remove those old references from the docs.
fluttergithubbot
added
the
framework
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
goderbauer
reviewed
Feb 19, 2020
| /// This semantic index is not necessarily the same as the index of the widget in | ||
| /// the scrollable, because some widgets may not contribute semantic | ||
| /// information. Consider a [new ListView.separated()]: every other widget is a | ||
| /// information. Consider a [ListView.separated()]: every other widget is a |
Member
There was a problem hiding this comment.
while you're in here: remove the () here and below?
Contributor
Author
There was a problem hiding this comment.
Oh, didn't see this comment, my apologies.
Member
|
Looks like the analyzer has detected some trailing whitespace: https://github.com/flutter/flutter/pull/51075/checks?check_run_id=456302126 Can you please remove those? Thanks! |
Contributor
Author
|
@goderbauer done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the new Dart versions allow us to omit the
newkeyword on constructors and most docs and examples follow this, I think its reasonable to remove those old references from the docs.Related Issues
I took the liberty to not opening an issue for something as simple as this, but if it's needed, please let me know and I will open one.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.