Fix doc typo in WidgetsApp.supportedLocales#51646
Merged
shihaohong merged 2 commits intoflutter:masterfrom Mar 2, 2020
shihaohong:locale-doc-fix
Merged
Fix doc typo in WidgetsApp.supportedLocales#51646shihaohong merged 2 commits intoflutter:masterfrom shihaohong:locale-doc-fix
shihaohong merged 2 commits intoflutter:masterfrom
shihaohong:locale-doc-fix
Conversation
added 2 commits
February 28, 2020 10:05
shihaohong
added
framework
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
shihaohong
changed the title
Contributor
|
I think the doc is OK (it appears to render correctly - https://master-api.flutter.dev/flutter/widgets/WidgetsApp/supportedLocales.html), markdown for numbered list items just has to show a leading number; any number. |
HansMuller
approved these changes
Mar 2, 2020
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM - although this is OK as is, it's a little easier to read with sensible item numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simple doc fix in
WidgetsApp.supportedLocales.