Skip to content

Fix paths causing test failures#52660

Merged
mit-mit merged 2 commits intoflutter:masterfrom
mit-mit:fixbuild
Mar 16, 2020
Merged

Fix paths causing test failures#52660
mit-mit merged 2 commits intoflutter:masterfrom
mit-mit:fixbuild

Conversation

@mit-mit
Copy link
Copy Markdown
Member

@mit-mit mit-mit commented Mar 16, 2020

Fix build error caused by #52532

  • time_to_development_benchmark__android
  • deploy_gallery-macos
[02:49:38]: 
Error in your Fastfile at line 32
[02:49:38]: 
    30:	
[02:49:38]: 
    31:	    # Relative to this file.
[02:49:38]: 
 => 32:	    raw_version = File.read('../../../../version')
[02:49:38]: 
    33:	    puts "Building and deploying version #{raw_version}..."
[02:49:38]: 
    34:	
[02:49:38]: 
No such file or directory @ rb_sysopen - ../../../../version

@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 16, 2020
@mit-mit
Copy link
Copy Markdown
Member Author

mit-mit commented Mar 16, 2020

Merging to fix the build, TBR @dnfield

@mit-mit mit-mit merged commit e36f4a4 into flutter:master Mar 16, 2020
@mit-mit mit-mit deleted the fixbuild branch March 16, 2020 13:51
Copy link
Copy Markdown
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lock
Copy link
Copy Markdown

lock Bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@lock lock Bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants