Re-land Luci Support for Gold#52760
Merged
fluttergithubbot merged 36 commits intoflutter:masterfrom Mar 18, 2020
Merged
Conversation
Updating pre-submit indicator
Piinks
added
a: tests
fluttergithubbot
added
the
f: cupertino
Piinks
commented
Mar 17, 2020
| && platform.environment.containsKey('GOLD_SERVICE_ACCOUNT'); | ||
|
|
||
| final bool luciPostSubmit = platform.environment.containsKey('SWARMING_TASK_ID') | ||
| && platform.environment.containsKey('GOLDCTL') |
| && platform.environment.containsKey('GOLD_SERVICE_ACCOUNT'); | ||
|
|
||
| final bool luciPreSubmit = platform.environment.containsKey('SWARMING_TASK_ID') | ||
| && platform.environment.containsKey('GOLDCTL') |
Contributor
Author
Contributor
|
|
13 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will re-land Luci support for Gold, which was reverted after it broke the dart build bot. The bot was running flutter framework tests on luci, so the change to re-land just factors in whether goldctl is available to restrict the golden test execution.
Tests
Updated luci tests.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.