Enable CupertinoContextMenu on Web#52977
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Mar 23, 2020
Merged
Conversation
justinmc
added
f: cupertino
This was referenced Mar 20, 2020
ferhatb
approved these changes
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CupertinoContextMenu is currently broken on web. This fixes it with the caveat that the small color mask during opening will not appear on web. Once ShaderMask is supported on web, the conditional in this PR can be removed, and web should work like other platforms.
Related Issues
#52967
#44152
#52766
Tests
I added a check that ShaderMask exists on non-web platforms and that it does not exist on the web.
I also manually verified that the CupertinoContextMenu docs example runs without error in the browser locally.
Breaking Change
Not a breaking change.