Skip to content

Remove SimControl from context and globals#53304

Merged
jmagman merged 1 commit intoflutter:masterfrom
jmagman:simcontrol
Mar 25, 2020
Merged

Remove SimControl from context and globals#53304
jmagman merged 1 commit intoflutter:masterfrom
jmagman:simcontrol

Conversation

@jmagman
Copy link
Copy Markdown
Member

@jmagman jmagman commented Mar 25, 2020

Related Issues

#47161

Tests

IOSSimulatorUtils is untested...

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 25, 2020
@jmagman jmagman self-assigned this Mar 25, 2020
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 25, 2020
@fluttergithubbot
Copy link
Copy Markdown
Contributor

fluttergithubbot commented Mar 25, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

christopherfujino
christopherfujino approved these changes Mar 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmagman jmagman merged commit ee3920c into flutter:master Mar 25, 2020
@jmagman jmagman deleted the simcontrol branch March 25, 2020 22:40
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmagman @fluttergithubbot @christopherfujino @googlebot