Skip to content

Turn metal on in the platform views benchmark#53676

Merged
blasten merged 1 commit intoflutter:masterfrom
blasten:metal_on
Mar 31, 2020
Merged

Turn metal on in the platform views benchmark#53676
blasten merged 1 commit intoflutter:masterfrom
blasten:metal_on

Conversation

@blasten
Copy link
Copy Markdown

@blasten blasten commented Mar 31, 2020

Description

Turn metal on in the platform views benchmark. Metal will be on by default, but I'd like to see how this benchmark behaves.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 31, 2020
@blasten blasten requested a review from cyanglaz March 31, 2020 18:51
Copy link
Copy Markdown
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blasten blasten merged commit 183b3c3 into flutter:master Mar 31, 2020
@blasten blasten deleted the metal_on branch March 31, 2020 18:56
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants