Add benchmark reproducing large static scrolling content#53686
Add benchmark reproducing large static scrolling content#53686fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
c: contributor-productivity
| import 'recorder.dart'; | ||
| import 'test_data.dart'; | ||
|
|
||
| /// The number of rows should be such that |
There was a problem hiding this comment.
Oops. Leftover. I moved this check into the constructor. Replaced with dartdocs.
| const double maxScrollExtent = kMaxSampleCount * kScrollDelta; | ||
| const double pictureHeight = kRows * kRowHeight; |
There was a problem hiding this comment.
I'm curious why these constants are here instead of at the top with the others?
There was a problem hiding this comment.
They are here for validation only, and they don't supply any new configuration for this benchmark. The ones at the top can be manually tweaked, unlike these that will always remain derivatives of the top-level constants.
ferhatb
left a comment
ferhatb
left a comment
There was a problem hiding this comment.
Other than comment /// The number of rows should be such that , lgtm
5 participants
Description
Add benchmark that reproduces #42987, i.e. a large piece of static content (a
Picturethat never changes) is scrolled. As the clip slides along the picture it causes repaints. Since our DOM operations are not culled, it causes jank proportional to the size of the picture.I will send a separate fix in flutter/engine, but want to get the benchmark first so we can validate the fix later.
Related Issues
#42987