Skip to content

Expose clipBehavior in simple dialog#74494

Closed
Amitpatil215 wants to merge 2 commits intoflutter:masterfrom
Amitpatil215:74414_dialog_clip
Closed

Expose clipBehavior in simple dialog#74494
Amitpatil215 wants to merge 2 commits intoflutter:masterfrom
Amitpatil215:74414_dialog_clip

Conversation

@Amitpatil215
Copy link
Copy Markdown
Contributor

@Amitpatil215 Amitpatil215 commented Jan 22, 2021

Description

  • Modified
    • adding clipBehavior property to the simpleDialog.
  • Earlier
    • There is no way to customize clipBehavior.

Related PR:

Earlier this /pull/50775 having modifications related to clipBehavior of Alert Dialog has been merged.

Issue

fixes #74414

Tests

I added tests to the dialog_test.dart that tests clipBehaviour properties.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jan 22, 2021
@google-cla google-cla Bot added the cla: yes label Jan 22, 2021
@Amitpatil215 Amitpatil215 changed the title clipBehaviour exposed in simple dialog Expose clipBehaviour in simple dialog Jan 22, 2021
@Amitpatil215 Amitpatil215 changed the title Expose clipBehaviour in simple dialog Expose clipBehavior in simple dialog Jan 22, 2021
@Amitpatil215 Amitpatil215 marked this pull request as ready for review January 22, 2021 17:31
@Amitpatil215
Copy link
Copy Markdown
Contributor Author

Amitpatil215 commented Jan 22, 2021

Closing this PR, already fix is in progress /pull/73571.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SimpleDialog doesn't clip on rounded corners

1 participant