Handle malformed UTF-8 in logcat streams #8864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
jason-simmons
force-pushed
the
logcat_ascii
branch
from
4dc8adc to
dd7685d
Compare
jason-simmons
changed the title
jason-simmons
force-pushed
the
logcat_ascii
branch
from
dd7685d to
048217d
Compare
Contributor
|
LGTM. Bonus points for a test. :-) |
Contributor
|
LGTM. Yeah, it would be great to have a test that pipes invalid UTF8 bytes through this code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.