Skip to content

Reland "[EditableText] honor the "brieflyShowPassword" system setting #97769 " #98150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2022
Merged

Reland "[EditableText] honor the "brieflyShowPassword" system setting #97769 " #98150

merged 2 commits into from
Feb 11, 2022

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Feb 9, 2022 •
edited
Loading

The previous pull request was reverted because we no longer need to force unwrap WidgetsBinding.instance.

Fixes #65352

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Feb 9, 2022
goderbauer
goderbauer approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 10, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 81464ff into flutter:master Feb 11, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
81464ff Reland "[EditableText] honor the "brieflyShowPassword" system…
7fcfa00 
… setting #97769 " (flutter/flutter#98150)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
81464ff Reland "[EditableText] honor the "brieflyShowPassword" system…
7be2371 
… setting #97769 " (flutter/flutter#98150)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
81464ff Reland "[EditableText] honor the "brieflyShowPassword" system…
221957f 
… setting #97769 " (flutter/flutter#98150)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
81464ff Reland "[EditableText] honor the "brieflyShowPassword" system…
f1d610c 
… setting #97769 " (flutter/flutter#98150)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
81464ff Reland "[EditableText] honor the "brieflyShowPassword" system…
1ffdb38 
… setting #97769 " (flutter/flutter#98150)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
81464ff Reland "[EditableText] honor the "brieflyShowPassword" system…
3ee0b77 
… setting #97769 " (flutter/flutter#98150)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
@engine-flutter-autoroll
81464ff Reland "[EditableText] honor the "brieflyShowPassword" system…
c475786 
… setting #97769 " (flutter/flutter#98150)
@LongCatIsLooong LongCatIsLooong deleted the reland-65352 branch February 11, 2022 17:03
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@LongCatIsLooong @clocksmith
Reland "[EditableText] honor the "brieflyShowPassword" system setting f…
07558fd 
…lutter#97769 " (flutter#98150)
@justinmc justinmc mentioned this pull request Jun 22, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@justinmc justinmc Awaiting requested review from justinmc

+1 more reviewer

@godofredoc godofredoc godofredoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flutter app still shows leading password character on Android even after disabling feature in settings (Security Vulnerability)

4 participants

@LongCatIsLooong @fluttergithubbot @goderbauer @godofredoc