[camera_avfoundation] Wrappers swift migration - part 1 #10119
Merged
+347
−568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertOdrowaz
requested review from
hellohuanlin and
vashworth
as code owners
RobertOdrowaz
force-pushed
the
feature/camera-wrappers-swift-migration-part1
branch
from
9cda6e1 to
a84d272
Compare
hellohuanlin
reviewed
Oct 1, 2025
packages/camera/camera_avfoundation/example/ios/RunnerTests/FLTCamSetFlashModeTests.swift
Outdated
Show resolved
Hide resolved
...es/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockCaptureVideoDataOutput.swift
Show resolved
Hide resolved
...mera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CamConfiguration.swift
Outdated
Show resolved
Hide resolved
...a_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraConfiguration.swift
Show resolved
Hide resolved
...mera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CamConfiguration.swift
Outdated
Show resolved
Hide resolved
...mera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CamConfiguration.swift
Outdated
Show resolved
Hide resolved
...mera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CamConfiguration.swift
Outdated
Show resolved
Hide resolved
...mera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CamConfiguration.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CaptureOutput.swift
Outdated
Show resolved
Hide resolved
RobertOdrowaz
force-pushed
the
feature/camera-wrappers-swift-migration-part1
branch
2 times, most recently
from
e008a0a to
bf2e952
Compare
…Output, FLTCapturePhotoOutput, FLTCaptureVideoDataOutput to Swift
RobertOdrowaz
force-pushed
the
feature/camera-wrappers-swift-migration-part1
branch
from
bf2e952 to
8b57a08
Compare
hellohuanlin
approved these changes
Oct 21, 2025
...a_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraConfiguration.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
...a_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraConfiguration.swift
Outdated
Show resolved
Hide resolved
RobertOdrowaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 23, 2025
flutter/packages@d113bbc...9ec29b6 2025-10-22 omar_hanafy@icloud.com [go_router] Support for top level `onEnter` callback. (flutter/packages#8339) 2025-10-22 katelovett@google.com [go_router_builder] Ignore experimental features (flutter/packages#10275) 2025-10-22 engine-flutter-autoroll@skia.org Roll Flutter from 2d34167 to 75004a6 (39 revisions) (flutter/packages#10279) 2025-10-22 47866232+chunhtai@users.noreply.github.com [ci]Adds mechanism for packages to opt in to batched release (flutter/packages#10237) 2025-10-22 1063596+reidbaker@users.noreply.github.com [tool] Change gradle-check logic to enforce alignment of java versions and a minimum (17) (flutter/packages#10206) 2025-10-22 eternalkaif@gmail.com [various] Migrate example Radio groups to new RadioGroup API (flutter/packages#10155) 2025-10-22 davidmartos96@gmail.com [mustache_template] Emoji support (flutter/packages#10110) 2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix typos in error messages for android (flutter/packages#10188) 2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix typos in error messages for platform interface (flutter/packages#10211) 2025-10-21 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers swift migration - part 1 (flutter/packages#10119) 2025-10-21 NearTox@outlook.com [go_router_builder] expand supported versions of analyzer, build and source_gen (flutter/packages#10078) 2025-10-20 engine-flutter-autoroll@skia.org Roll Flutter from 891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 24, 2025
flutter/packages@d113bbc...9ec29b6 2025-10-22 omar_hanafy@icloud.com [go_router] Support for top level `onEnter` callback. (flutter/packages#8339) 2025-10-22 katelovett@google.com [go_router_builder] Ignore experimental features (flutter/packages#10275) 2025-10-22 engine-flutter-autoroll@skia.org Roll Flutter from 2d34167 to 75004a6 (39 revisions) (flutter/packages#10279) 2025-10-22 47866232+chunhtai@users.noreply.github.com [ci]Adds mechanism for packages to opt in to batched release (flutter/packages#10237) 2025-10-22 1063596+reidbaker@users.noreply.github.com [tool] Change gradle-check logic to enforce alignment of java versions and a minimum (17) (flutter/packages#10206) 2025-10-22 eternalkaif@gmail.com [various] Migrate example Radio groups to new RadioGroup API (flutter/packages#10155) 2025-10-22 davidmartos96@gmail.com [mustache_template] Emoji support (flutter/packages#10110) 2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix typos in error messages for android (flutter/packages#10188) 2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix typos in error messages for platform interface (flutter/packages#10211) 2025-10-21 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers swift migration - part 1 (flutter/packages#10119) 2025-10-21 NearTox@outlook.com [go_router_builder] expand supported versions of analyzer, build and source_gen (flutter/packages#10078) 2025-10-20 engine-flutter-autoroll@skia.org Roll Flutter from 891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates camera wrappers as part of flutter/flutter#119109
This PR migrates wrappers to Swift:
FLTCamConfigurationFLTCamMediaSettingsAVWrapperFLTCaptureOutputFLTCapturePhotoOutputFLTCaptureVideoDataOutputIn line with Swift conventions, the
FLTprefixes are removed. TheDefaultclass implementations are replaced with protocol conformance on baseAVclasses.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3