[go_router_builder] Ignore experimental features #10275

Piinks · 2025-10-22T00:20:08Z

Unblock upstream analyzer change.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

Piinks · 2025-10-22T00:21:08Z

@stereotype441 can you confirm this resolves the issue? We cannot know for sure since it is upstream.

gemini-code-assist

Code Review

This pull request aims to address the use of experimental features from an upstream analyzer package by adding ignore comments. While this is a good step, the changes are incomplete as one of the experimental API usages is not being ignored. I've provided a suggestion to not only fix this omission but also to improve the code's readability by extracting the experimental properties into local variables, which centralizes the suppression comments.

gemini-code-assist · 2025-10-22T00:21:32Z

packages/go_router_builder/lib/src/type_helpers.dart

+    // ignore: experimental_member_use
    if (functionType.formalParameters.length != 1 ||
        functionType.returnType.getDisplayString() !=
            type.element.typeParameters.first.displayName ||
+        // ignore: experimental_member_use
        functionType.formalParameters[0].type.getDisplayString() != 'Object?') {


You've added ignore comments for formalParameters, but functionType.returnType on line 800 is also an experimental member and is missing an ignore comment. This could lead to analyzer warnings.

To make this cleaner and ensure all experimental usages are covered, consider extracting the properties that use experimental APIs into local variables. This localizes the suppression comments and improves the readability of the if condition.

Suggested change

// ignore: experimental_member_use

if (functionType.formalParameters.length != 1 ||

functionType.returnType.getDisplayString() !=

type.element.typeParameters.first.displayName ||

// ignore: experimental_member_use

functionType.formalParameters[0].type.getDisplayString() != 'Object?') {

// ignore: experimental_member_use

final List<ParameterElement> formalParameters = functionType.formalParameters;

// ignore: experimental_member_use

final DartType returnType = functionType.returnType;

if (formalParameters.length != 1 ||

returnType.getDisplayString() !=

type.element.typeParameters.first.displayName ||

formalParameters[0].type.getDisplayString() != 'Object?') {

You've added ignore comments for formalParameters, but functionType.returnType on line 800 is also an experimental member and is missing an ignore comment. This could lead to analyzer warnings.

Hopefully everyone takes AI code reviews with a grain of salt, but just in case someone is thinking of applying this suggestion: I see no evidence to back up this claim. AFAICT, FunctionType.returnType is not an experimental member, and I don't believe it ever has been.

davidmorgan · 2025-10-22T07:26:00Z

If I understood correctly, the problem is with Dart from main and analyzer 8.1.0.

With that setup and flutter/package at 37f0bb0 I get analysis warnings

warning • lib/src/route_config.dart:626:34 • 'element' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/route_config.dart:945:32 • 'element' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/type_helpers.dart:228:16 • 'element' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/type_helpers.dart:231:48 • 'element' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/type_helpers.dart:798:22 • 'formalParameters' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/type_helpers.dart:800:18 • 'element' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/type_helpers.dart:801:22 • 'formalParameters' is experimental and could be removed or changed at any time. • experimental_member_use

so I think you need more ignores, like this

davidmorgan#1

Edit: I'm not sure why the warnings for 'element' that I saw are not in the original trybot failure, or at least not in the output I saw in chat, but it's harmless to ignore them.

stereotype441 · 2025-10-22T13:15:45Z

@davidmorgan

If I understood correctly, the problem is with Dart from main and analyzer 8.1.0.

With that setup and flutter/package at 37f0bb0 I get analysis warnings

warning • lib/src/route_config.dart:626:34 • 'element' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/route_config.dart:945:32 • 'element' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/type_helpers.dart:228:16 • 'element' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/type_helpers.dart:231:48 • 'element' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/type_helpers.dart:798:22 • 'formalParameters' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/type_helpers.dart:800:18 • 'element' is experimental and could be removed or changed at any time. • experimental_member_use
warning • lib/src/type_helpers.dart:801:22 • 'formalParameters' is experimental and could be removed or changed at any time. • experimental_member_use

so I think you need more ignores, like this

davidmorgan#1

Edit: I'm not sure why the warnings for 'element' that I saw are not in the original trybot failure, or at least not in the output I saw in chat, but it's harmless to ignore them.

It looks from https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8700308398682324417/+/u/analyze_Flutter_repositories/stdout like the flutter-analyze and flutter-analyze-try bots are analyzing go_router_config against analyzer version 7.4.0. In that version, InterfaceType.element had not yet been marked @experimental, so that's the reason the warnings for element showed up for you and not on the bot.

But I agree that it would be harmless to go ahead and ignore them as well.

stereotype441

lgtm. I'm fine either with @davidmorgan's additional suggested ignores or without.

Piinks · 2025-10-22T15:36:58Z

From a separate chat: "I don't believe the additional ignores suggested are necessary (his analysis was based on a different analyzer version than the version the bot is using). "

I am going to land this as is for now to resolve the original blocker raised.

chunhtai

LGTM

…ackages#10275)

flutter/packages@d113bbc...9ec29b6 2025-10-22 omar_hanafy@icloud.com [go_router] Support for top level `onEnter` callback. (flutter/packages#8339) 2025-10-22 katelovett@google.com [go_router_builder] Ignore experimental features (flutter/packages#10275) 2025-10-22 engine-flutter-autoroll@skia.org Roll Flutter from 2d34167 to 75004a6 (39 revisions) (flutter/packages#10279) 2025-10-22 47866232+chunhtai@users.noreply.github.com [ci]Adds mechanism for packages to opt in to batched release (flutter/packages#10237) 2025-10-22 1063596+reidbaker@users.noreply.github.com [tool] Change gradle-check logic to enforce alignment of java versions and a minimum (17) (flutter/packages#10206) 2025-10-22 eternalkaif@gmail.com [various] Migrate example Radio groups to new RadioGroup API (flutter/packages#10155) 2025-10-22 davidmartos96@gmail.com [mustache_template] Emoji support (flutter/packages#10110) 2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix typos in error messages for android (flutter/packages#10188) 2025-10-22 38378650+hgraceb@users.noreply.github.com [image_picker] Fix typos in error messages for platform interface (flutter/packages#10211) 2025-10-21 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers swift migration - part 1 (flutter/packages#10119) 2025-10-21 NearTox@outlook.com [go_router_builder] expand supported versions of analyzer, build and source_gen (flutter/packages#10078) 2025-10-20 engine-flutter-autoroll@skia.org Roll Flutter from 891d7d5 to 2d34167 (18 revisions) (flutter/packages#10268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Ignore experimental features

3e949b6

Piinks requested a review from chunhtai as a code owner October 22, 2025 00:20

Piinks added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Oct 22, 2025

github-actions bot added the p: go_router_builder label Oct 22, 2025

Piinks requested a review from stereotype441 October 22, 2025 00:20

gemini-code-assist bot reviewed Oct 22, 2025

View reviewed changes

stereotype441 approved these changes Oct 22, 2025

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2025

Piinks mentioned this pull request Oct 22, 2025

Fixing deps for build_runner in flutter/packages broke Dart infra flutter/flutter#177393

Open

chunhtai approved these changes Oct 22, 2025

View reviewed changes

auto-submit bot merged commit 36265f6 into flutter:main Oct 22, 2025
80 checks passed

engine-flutter-autoroll mentioned this pull request Oct 23, 2025

Roll Packages from d113bbc1107e to 9ec29b6d23e7 (12 revisions) flutter/flutter#177455

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2025

36265f6a4 [go_router_builder] Ignore experimental features (flutter/p…

e581be8

…ackages#10275)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[go_router_builder] Ignore experimental features #10275

[go_router_builder] Ignore experimental features #10275

Piinks commented Oct 22, 2025

Uh oh!

Piinks commented Oct 22, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Oct 22, 2025

Uh oh!

stereotype441 Oct 22, 2025

Uh oh!

davidmorgan commented Oct 22, 2025 •

edited

Loading

Uh oh!

stereotype441 commented Oct 22, 2025

Uh oh!

stereotype441 left a comment

Uh oh!

Piinks commented Oct 22, 2025

Uh oh!

chunhtai left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[go_router_builder] Ignore experimental features #10275

[go_router_builder] Ignore experimental features #10275

Conversation

Piinks commented Oct 22, 2025

Pre-Review Checklist

Footnotes

Uh oh!

Piinks commented Oct 22, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

stereotype441 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

davidmorgan commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stereotype441 commented Oct 22, 2025

Uh oh!

stereotype441 left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Oct 22, 2025

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

davidmorgan commented Oct 22, 2025 •

edited

Loading