[in_app_purchase_storekit] Expose expiration date directly for subscriptions - #11551
Merged
Conversation
LouiseHsu
marked this pull request as ready for review
April 28, 2026 23:48
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| /// This is the value set when making the purchase via appAccountToken option. | ||
| final String? appAccountToken; | ||
|
|
||
| /// The date the subscription expires or renews. |
Contributor
There was a problem hiding this comment.
To improve clarity for developers, please document the format of the expirationDate string. For consistency with PurchaseDetails.transactionDate, it should be specified as milliseconds since the epoch.
Suggested change
| /// The date the subscription expires or renews. | |
| /// The date the subscription expires or renews, in milliseconds since epoch. |
Contributor
There was a problem hiding this comment.
This sounds reasonable?
Contributor
There was a problem hiding this comment.
nit: maybe also say this is null if the purchased produce is not a subscription?
LouiseHsu
changed the title
Collaborator
|
From triage: @LouiseHsu Was this supposed to be routed to someone on iOS for review? |
LongCatIsLooong
approved these changes
Jul 24, 2026
LongCatIsLooong
left a comment
LongCatIsLooong
left a comment
Contributor
There was a problem hiding this comment.
LGTM, Sorry for the delay
| /// This is the value set when making the purchase via appAccountToken option. | ||
| final String? appAccountToken; | ||
|
|
||
| /// The date the subscription expires or renews. |
Contributor
There was a problem hiding this comment.
This sounds reasonable?
| /// This is the value set when making the purchase via appAccountToken option. | ||
| final String? appAccountToken; | ||
|
|
||
| /// The date the subscription expires or renews. |
Contributor
There was a problem hiding this comment.
nit: maybe also say this is null if the purchased produce is not a subscription?
LouiseHsu
force-pushed
the
subscriptions
branch
from
August 27, 2026 20:55
5de7ff5 to
b0ff15f
Compare
LouiseHsu
force-pushed
the
subscriptions
branch
from
September 10, 2026 20:32
b0ff15f to
92b3b42
Compare
LouiseHsu
added
the
autosubmit
pull Bot
pushed a commit
to Mattlk13/flutter
that referenced
this pull request
Sep 11, 2026
…r#192630) flutter/packages@8a35b16...9caa77c 2026-09-11 tarrinneal@gmail.com [pigeon] main actor async flutter api (flutter/packages#12729) 2026-09-10 matt.boetger@gmail.com [image_picker] Handle a null stream from openInputStream (flutter/packages#12718) 2026-09-10 47866232+chunhtai@users.noreply.github.com [material_ui] 1.2.0 sync back clean up (flutter/packages#12829) 2026-09-10 50643541+Mairramer@users.noreply.github.com [material_ui] Support custom date input formatters via CalendarDelegate (flutter/packages#12608) 2026-09-10 louisehsu@google.com [in_app_purchase_storekit] Expose expiration date directly for subscriptions (flutter/packages#11551) 2026-09-10 matt.boetger@gmail.com [file_selector_android] Handle a null stream from openInputStream (flutter/packages#12716) 2026-09-10 tarrinneal@gmail.com [pigeon] Add FFI and JNI support to Swift and Kotlin (flutter/packages#11352) 2026-09-10 36861262+QuncCccccc@users.noreply.github.com [material_ui] Migrate M3 Card defaults to new gen_defaults (flutter/packages#12795) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a potential cause of flutter/flutter#181530
Quite a few IAP bugs seem to be surrounding stale data, so expose the expiration date directly to have to avoid doing local receipt shenanigans.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].