[material_ui] Migrate AppBar M3 template to use new gen_defaults script#12122
Draft
QuncCccccc wants to merge 1 commit into
Draft
[material_ui] Migrate AppBar M3 template to use new gen_defaults script#12122QuncCccccc wants to merge 1 commit into
QuncCccccc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12121 should be landed first since it contains some helper functions that this PR uses.
Fixes flutter/flutter#188397
Initially gen_defaults script and its templates were used to handle JSON tokens. After we fix the token pipeline and make it possible to get M3E tokens, we use Dart constants and re-created the gen_defaults in material_ui. After decoupling, the old gen_defaults will be deprecated soon.
This PR is to:
AppBarso we can use new script to generate M3 defaults.generated/folder so all M3 and M3E generated code will be in the same location.Pre-Review Checklist
[shared_preferences]///).