[material_ui, cupertino_ui] Rename l10n macros#12211
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation macro names for Cupertino and Material localizations from 'flutter.localizations.' to 'cupertino_ui.localizations.' and 'material_ui.localizations.*'. However, the generated Material localizations file is missing the corresponding macro rename, which should be updated to prevent out-of-sync documentation templates.
dkwingsmt
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/12211, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dkwingsmt
added
the
autosubmit
…er#189659) flutter/packages@9f95026...4fdc766 2026-07-17 tarrinneal@gmail.com [pigeon] allow empty class (flutter/packages#12181) 2026-07-16 dkwingsmt@users.noreply.github.com [material_ui, cupertino_ui] Rename l10n macros (flutter/packages#12211) 2026-07-16 stuartmorgan@google.com [ci] Remove manual SwiftPM enabling step (flutter/packages#12204) 2026-07-16 stuartmorgan@google.com [google_maps_flutter] Fix XCUITest on stable (flutter/packages#12214) 2026-07-16 stuartmorgan@google.com [google_maps_flutter] Convert XCUITests to Swift (flutter/packages#12208) 2026-07-16 dkwingsmt@users.noreply.github.com [material_ui] Rename the remaining templates (flutter/packages#12210) 2026-07-15 dkwingsmt@users.noreply.github.com [material_ui, cupertino_ui] Rename macro names to package names (flutter/packages#12198) 2026-07-15 katelovett@google.com [material_ui] Fix upstream localization test (flutter/packages#12207) 2026-07-15 stuartmorgan@google.com [material_ui, cupertino_ui] Localizations (flutter/packages#12119) 2026-07-15 codefu@google.com fix(ci): harden some workflows in packages (flutter/packages#12178) 2026-07-15 engine-flutter-autoroll@skia.org Roll Flutter from 846664b to fc1ad95 (18 revisions) (flutter/packages#12203) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
This PR renames macros used by l10n.
For why the rename is needed, see #12198.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2