[material_ui] Migrate M3 Banner template to use new gen_defaults - #12227
Merged
QuncCccccc merged 5 commits intoAug 12, 2026
Merged
Conversation
github-actions
Bot
added
triage-framework
QuncCccccc
force-pushed
the
banner_m3_defaults_migration
branch
4 times, most recently
from
August 6, 2026 22:04
c1e5eea to
a6f4331
Compare
QuncCccccc
force-pushed
the
banner_m3_defaults_migration
branch
from
August 7, 2026 22:18
38a8621 to
564c2e2
Compare
QuncCccccc
changed the title
Banner template to use new gen_defaults
QuncCccccc
marked this pull request as ready for review
August 7, 2026 23:03
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the generation of Material 3 Banner defaults to the token-based generator system. It removes the inline _BannerDefaultsM3 class from banner.dart and references it as a generated part file. It introduces BannerTemplateM3 to generate the defaults from design tokens, enables this template in the generator script, and adds unit tests to verify the generated code. There are no review comments, and I have no feedback to provide.
elliette
approved these changes
Aug 11, 2026
|
|
||
| // import '../templates/bottom_app_bar_template.dart'; | ||
| import '../templates/bottom_sheet_template.dart'; | ||
|
|
| // import '../templates/badge_template.dart'; | ||
| // import '../templates/banner_template.dart'; | ||
| import '../templates/banner_template.dart'; | ||
|
|
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#187899
Fixes flutter/flutter#188402
Pre-Review Checklist
[shared_preferences]///).