[animations] optimize open container opacity usage#2626
Merged
auto-submit[bot] merged 4 commits intoflutter:mainfrom Sep 21, 2022
Merged
[animations] optimize open container opacity usage#2626auto-submit[bot] merged 4 commits intoflutter:mainfrom
auto-submit[bot] merged 4 commits intoflutter:mainfrom
Conversation
goderbauer
approved these changes
Sep 20, 2022
| final NavigatorState navigator = tester.state(find.byType(Navigator)); | ||
| navigator.pop(); | ||
| await tester.pump(); | ||
| await tester.pump(); |
Contributor
Author
There was a problem hiding this comment.
From offline discussion, we were previously looking up the wrong opacity.
jonahwilliams
commented
Sep 20, 2022
| ); | ||
|
|
||
| // Regression test for https://github.com/flutter/flutter/issues/72238. | ||
| testWidgets( |
Contributor
Author
There was a problem hiding this comment.
This test was always grabbing the wrong opacity and never actually tested the issue in question
jonahwilliams
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Opacity with Visibility. On newer framework versions, visibility will be much faster as it does not create an opacity layer.
Replace manually animated opacity widgets with a FadeTransition. On newer framework versions, the opacity animated via fade transition has some performance enhancements for stable subtrees that do not apply to the regular opacity render object