-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Adds platform-specific IDs, new "show interstitial" button to AdMob example #327
Conversation
|
These changes look good, thank you! Once Travis approves I'll update the version number, land the PR, and publish a new version of the plugin. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Thanks! |
|
Published as 0.2.2 https://pub.dartlang.org/packages/firebase_admob |
|
I will review #328 soon, a little swamped at the moment |
|
No problem. I'm mostly done with the iOS and Android implementations, and was planning to add them to the PR in a day or two, so it'd probably be more efficient to hold off anyway. |
…xample (flutter#327) * Updates to firebase-admob example * Correcting CHANGELOG punctuation * Update to version 0.2.2
This is a clean redo of PR #312, of which I made a mess when attempting to rebase onto upstream changes. There shouldn't be anything in here other than code changes to the firebase-admob example, a version bump to the pubspec, and a corresponding CHANGLEOG update.
The changes to the example are: