Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@redbrogdon
Copy link
Contributor

This is a clean redo of PR #312, of which I made a mess when attempting to rebase onto upstream changes. There shouldn't be anything in here other than code changes to the firebase-admob example, a version bump to the pubspec, and a corresponding CHANGLEOG update.

The changes to the example are:

  • Load and Show functionality for interstitials has been separated into two separate buttons, which is more in line with our best practices for AdMob.
  • Separate, platform-specific ad unit IDs and App IDs have been added.

@HansMuller
Copy link
Contributor

These changes look good, thank you!

Once Travis approves I'll update the version number, land the PR, and publish a new version of the plugin.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added cla: no and removed cla: yes labels Jan 4, 2018
@HansMuller HansMuller merged commit a4f2b2c into flutter:master Jan 4, 2018
@redbrogdon
Copy link
Contributor Author

Thanks!

@HansMuller
Copy link
Contributor

Published as 0.2.2 https://pub.dartlang.org/packages/firebase_admob

@HansMuller
Copy link
Contributor

I will review #328 soon, a little swamped at the moment

@redbrogdon
Copy link
Contributor Author

No problem. I'm mostly done with the iOS and Android implementations, and was planning to add them to the PR in a day or two, so it'd probably be more efficient to hold off anyway.

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
…xample (flutter#327)

* Updates to firebase-admob example

* Correcting CHANGELOG punctuation

* Update to version 0.2.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants