This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[WIP] Flutter API for AdMob rewarded video ads #328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README.md Added detail about the need to configure firebase for each platform project: Android and iOS * Update README.md
Demo GIF image doesn't work on pub site because link is relative rather than absolute. Need to resubmit the readme for the video package.
* Add missing `break` Without the break statement, `addDocumentListener` was falling through to `removeListener`. * Remove todo * Update CHANGELOG.md * Update pubspec.yaml
* Use safe area layout to place ad in iOS 11 * Fix indentation for the format test * Factor pre-iOS11 placement code into its own method * Remove extra spaces for format test and improve the compiler directive * Add larsenthomasj@gmail.com to AUTHORS * Update version to 0.2.1 * Add 0.2.1 entry
…xample (flutter#327) * Updates to firebase-admob example * Correcting CHANGELOG punctuation * Update to version 0.2.2
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Contributor
Author
|
Closing this to create a final PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR containing changes to the developer-facing Dart API for AdMob that will add support for rewarded video ads. It's built on top of the changes in PR #327, so those commits show up here as well. The only important code to look at is in firebase_admob.dart, though, since that contains the interface.
Some questions I'd love to get answers for: