firebase_messaging: changing getToken to rely on platform's getToken by ffeu · Pull Request #789 · flutter/plugins · GitHub

This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Contributor

ffeu commented Sep 20, 2018 •

edited

Loading

intends to fix flutter/flutter#17699 and fix flutter/flutter#20378

Removing local cache of getToken() in the dart part of the plugin. Now getToken() calls directly its counterparts in the iOS and Android implementations. This enables obtaining its value without calling configure() or having to wait for a new token refresh.

ffeu added 2 commits

September 20, 2018 12:35


          changing plugin getToken to call platforms getTokens

e3df00e


          changing plugin getToken to call platforms getTokens

googlebot added the cla: yes label


          making test format happy and adjusting tests accordingly

a91aa93

Contributor Author

ffeu commented Sep 20, 2018

@kroikie let me know if there's any improvement, tested on real devices on iOS and Android


          Add support for handling UserRecoverableAuthException (flutter#771)

b889b40

buntagonalprism mentioned this pull request

firebaseMessaging.getToken() fails to return an FCM token, blocks forever in await flutter/flutter#20378

Closed

mehmetf and others added 4 commits

September 24, 2018 17:15


          Switch over to new GoogleSignIn APIs (flutter#792)

6341d3a

This is a massive cleanup that is not supposed to alter any functionality. Will roll into google and test.


          use WidgetsBindingObserver as a mixin (flutter#797)

46b5486


          Ban string values which clash with special prefixes (flutter#798)

0ff11a5


          Added updatePassword functionality to firebase_auth plugin. (flutte…

aa694d4

…r#678)

Add updatePassword functionality to firebase_auth plugin.

Contributor Author

ffeu commented Sep 27, 2018

@kroikie BTW, there's this one too. it closes two issues! 😀

mehmetf and others added 16 commits

September 27, 2018 14:45


          Add ability to clear auth cache on Android (flutter#799)

a44b105


          Move SystemChrome update to framework side (flutter#800)

e6c8b92


          Unregister the activity lifecycle callbacks when disposing the camera (…

031310a

…flutter#645)


          Allow latest version for MLVision on ios (flutter#804)

eff94c1


          add option to enable javascript in android webview (flutter#796)

212c3e5


          Bump camera version (flutter#802)

26ad3ea


          Handle user cancel when signing in (flutter#805)

07176dd


          Convert list to object array when using FieldValue (flutter#795)

f7d1985


          Bump version for flutter#795 (flutter#808)

4b13e56


          Check activity isFinishing before authentication (flutter#807)

284822d


          Add page names for firebaseopensource.com (flutter#811)

557bb90


          Set http version to be compatible with flutter_test (flutter#810)

894f2dd

* Set http version to be compatible with flutter_test


          Added android device id to android device info (flutter#639)

e6f85ba

* Added android device id to android device info

* Bumped device info to version 0.3.0


          Set http version to be compatible with flutter_test (flutter#812)

084828f


           adding support auth link for Twitter (flutter#697)

df583bc

* adding support auth link for Twitter


          [Firebase Auth] added access to User metadata (flutter#718)

e920cf7

* add access to user metadata

calebisstupid commented Oct 3, 2018

This PR fixes the hanging getToken() call for me in simulator as well.


          Bump Android dependencies to latest (flutter#821)

96a3a5a

kroikie and others added 4 commits

October 12, 2018 13:59


          Bump firebase_performance Android dependencies to latest. (flutter#847)

645154d


          Bump firebase_remote_config Android dependencies to latest. (flutter#848

ae0923d

)

* Bump firebase_remote_config Android dependencies to latest.

* Bump pubspec version


          Bump firebase_ml_vision Android dependencies to latest (flutter#846)

70a4ffc

* Bump firebase_ml_fision Android dependencies to latest

* bump pubspec version


          Add clearMarkers() functionality to GoogleMapController (flutter#843)

ab6d93d

Add clearMarkers() functionality to GoogleMapController. This method will clear all markers currently present on the map.

beardo01 commented Oct 13, 2018

Can also confirm that this has fixed the getToken() hanging issue for me. Another respectful ping to @kroikie to accept this.

pdefuns and others added 2 commits

October 15, 2018 08:48


          Add biometry type detection to local_auth plugin (flutter#845)

a211895

Now the users can determine two things:
- Whether the phone is capable of biometrics.
- Whether any biometric checks are available to the app.


          Reformat the marker id getter comment. (flutter#828)

e3afc1f

muirandy commented Oct 16, 2018

I'm new to Flutter and am evaluating it for use with Firebase. This plugin is obviously important!
I've been through a tutorial, and it behaves inconsistently - I believe this PR is the fix.

a14n and others added 7 commits

October 16, 2018 15:11


          remove unnecessary new from samples (flutter#818)

60eeff0


          Change webview and maps to use gesture factories. (flutter#778)

30898fd

Matches the change in flutter/flutter#21657


          Change android invites dependency to dynamic links (flutter#853)

41824d8


          changing plugin getToken to call platforms getTokens

3fa163a


          changing plugin getToken to call platforms getTokens

9d7e524


          making test format happy and adjusting tests accordingly

1161b2d


          rebasing, changing version to 2.0.2

a305cc9

googlebot commented Oct 16, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

googlebot added cla: no and removed cla: yes labels

Contributor Author

ffeu commented Oct 16, 2018

yeah, i messed up this branch/PR. :(

sorry about that, I'll have to recreate it in another PR.

beardo01 commented Oct 22, 2018

@ffeu Please do and make sure you reference it from this Pull Request so I can come and show my support. Cheers!

4 similar comments

beardo01 commented Oct 22, 2018

@ffeu Please do and make sure you reference it from this Pull Request so I can come and show my support. Cheers!

beardo01 commented Oct 22, 2018

@ffeu Please do and make sure you reference it from this Pull Request so I can come and show my support. Cheers!

beardo01 commented Oct 22, 2018

@ffeu Please do and make sure you reference it from this Pull Request so I can come and show my support. Cheers!

beardo01 commented Oct 22, 2018

@ffeu Please do and make sure you reference it from this Pull Request so I can come and show my support. Cheers!

Contributor

Hixie commented Oct 24, 2018

@ffeu Are you planning on submitting a new PR as per your comment above?

Contributor Author

ffeu commented Oct 24, 2018

@Hixie yes, give me just a few minutes

ffeu mentioned this pull request

[firebase_messaging] changing getToken to rely on platform's getToken (2) #869

Merged

Contributor Author

ffeu commented Oct 24, 2018

replaced by #869

ffeu closed this

ffeu deleted the gettoken_platform branch

November 16, 2018 13:59

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

25 participants