Skip to content

Update simple_sdf sample to use uniform-by-name accessor#2843

Merged
andywolff merged 1 commit into
flutter:mainfrom
andywolff:simple_sdf_uniform_by_name
May 18, 2026
Merged

Update simple_sdf sample to use uniform-by-name accessor#2843
andywolff merged 1 commit into
flutter:mainfrom
andywolff:simple_sdf_uniform_by_name

Conversation

@andywolff
Copy link
Copy Markdown
Contributor

The newer, more convenient method getUniformVec2 is now available on stable, so let's use that in the simple_sdf sample

Pre-launch Checklist

@andywolff andywolff requested a review from gaaclarke May 14, 2026 17:15
@andywolff andywolff marked this pull request as ready for review May 14, 2026 17:15
Copy link
Copy Markdown
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we need to wait a couple of days for 3.44 to land on stable before landing this. You can double check against stable, but I don't think it should work.

@andywolff
Copy link
Copy Markdown
Contributor Author

LGTM, but I think we need to wait a couple of days for 3.44 to land on stable before landing this. You can double check against stable, but I don't think it should work.

Confirmed this does not render in chrome on stable (3.41) but does work on 3.44. I'll wait for that before merging.

@andywolff
Copy link
Copy Markdown
Contributor Author

3.44 has landed, merging this PR

@andywolff andywolff merged commit bf6cdc1 into flutter:main May 18, 2026
4 checks passed
@andywolff andywolff deleted the simple_sdf_uniform_by_name branch May 18, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants