Skip to content

Animation Sample:Demonstration of AnimatedSwitcher#368

Closed
farheen21 wants to merge 3 commits intoflutter:masterfrom
farheen21:master
Closed

Animation Sample:Demonstration of AnimatedSwitcher#368
farheen21 wants to merge 3 commits intoflutter:masterfrom
farheen21:master

Conversation

@farheen21
Copy link
Copy Markdown

Made an animation sample by using AnimatedSwticher

20200312_154834

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@farheen21
Copy link
Copy Markdown
Author

@redbrogdon @kwalrath @johnpryan Needs your reviews here.

@farheen21
Copy link
Copy Markdown
Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
* It's possible we don't have your GitHub username or you're using a different email address on your commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).
Corporate signers
* Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to [go/cla#troubleshoot](http://go/cla#troubleshoot) ([Public version](https://opensource.google/docs/cla/#troubleshoot)).

* The email used to register you as an authorized contributor must be the email used for the Git commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).

* The email used to register you as an authorized contributor must also be [attached to your GitHub account](https://github.com/settings/emails).

ℹ️ Googlers: Go here for more info.

@googlebot i signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@johnpryan
Copy link
Copy Markdown
Contributor

Hi @farheen21, thanks for the pull request. Did you know we also have an AnimatedSwitcher example in the docs? https://api.flutter.dev/flutter/widgets/AnimatedSwitcher-class.html

@redbrogdon @gspencergoog do you know if the AnimatedSwitcher example in the docs will get a DartPad version?

@gspencergoog
Copy link
Copy Markdown

Well, there weren't any plans for it, but it was easy enough, so I did: see flutter/flutter#52547

@gspencergoog gspencergoog requested review from johnpryan and removed request for johnpryan March 13, 2020 16:40
@johnpryan
Copy link
Copy Markdown
Contributor

@farheen21 Thanks for making a PR. We are generally looking for contributions to be "fixes and necessary improvements". This is looks like of a technique to create a toggle-switch widget using an AnimatedPositioned with an AnimatedSwitcher. Also, this isn't one of the basic building blocks and patterns we want to cover in the basics section, so I'm going to close the issue. Filing issues before submitting pull requests can help validate contribution ideas first.

Thanks!

@johnpryan johnpryan closed this Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants