[ Fixed Issue #667 ] Add Google and Unsplash terms links to experimental/desktop_photo_search #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SatYu26
changed the title
Contributor
Author
|
@domesticmouse Sir i solved the issue but there seems to be some checks that have not cleared.
|
domesticmouse
requested changes
Jan 28, 2021
Contributor
domesticmouse
left a comment
domesticmouse
left a comment
There was a problem hiding this comment.
First up, thanks for the PR!
Please review the CI pipeline and correct the issue(s) that it notes. We can't land a PR that is red. Thanks for your assistance =)
brett
| import 'src/widgets/photo_search_dialog.dart'; | ||
| import 'src/widgets/split.dart'; | ||
| import 'unsplash_access_key.dart'; | ||
| import 'src/widgets/about_dialog.dart'; |
Contributor
There was a problem hiding this comment.
Can you please re-order these imports to be alphabetical? The following error is showing up in the CI
info • Sort directive sections alphabetically • lib/main.dart:22:1 • directives_ordering
domesticmouse
approved these changes
Jan 28, 2021
Contributor
|
Thank you! |
Contributor
Author
|
@domesticmouse Thank you sir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issue #667
I have made few changes according to the requirement in this issue.
As of now the dialog looks like this:
I have added sentences according to the information available to me but if you let me know the specific details of the statements i will make those changes quickly.
Also i have added the access point for this dialog in About menu inside the menubar, As you can see in this picture.
I will can make more changes also if required by you.