Fix carousel alignment issue #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2021
johnpryan
approved these changes
Jan 29, 2021
Contributor
johnpryan
left a comment
johnpryan
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the quick fix!
| opacity: 0.2; | ||
| cursor: pointer; | ||
| transition: 40ms ease; | ||
| transition: 200ms ease; |
Contributor
There was a problem hiding this comment.
Is this part of the fix or just something that should be changed?
Contributor
Author
There was a problem hiding this comment.
no, not really :) I increased it to give some smoothness to the animation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #683
Fixes #684
Fixes #690
Currently, the carousel overlays with the launch app and source code buttons, and some tags. This will fix those alignment issues and make the buttons and tags clickable.