Reduce Liquid logic on china community page#12547
Conversation
Summary of ChangesHello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request simplifies the China community page by removing complex Liquid templating in favor of duplicated but more maintainable hardcoded content. The changes are well-aligned with the stated goal. I've found some minor formatting issues in the new markdown content that would lead to incorrect rendering of ordered lists. My review comments provide details on how to fix them. Overall, this is a good improvement for maintainability.
|
Visit the preview URL for this PR (updated for commit c8de86d): https://flutter-docs-prod--pr12547-misc-simplify-use-in-china-redp7hxp.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
Sounds good to me! lgtm
This PR keeps the contents of the page mostly the same but reduces the use of complicated Liquid templating and includes. This does result in a little bit more duplication, but will be easier to maintain and keep compatible with future site infrastructure.
Staged: https://flutter-docs-prod--pr12547-misc-simplify-use-in-china-redp7hxp.web.app/community/china