Skip to content

Follow-up adjustments to i18n decoupling changes - #13710

Merged
parlough merged 1 commit into
mainfrom
misc/i18n-decoupling-cleanup
Aug 12, 2026
Merged

Follow-up adjustments to i18n decoupling changes#13710
parlough merged 1 commit into
mainfrom
misc/i18n-decoupling-cleanup

Conversation

@parlough

@parlough parlough commented Aug 11, 2026

Copy link
Copy Markdown
Member

Follow-up adjustments to #13692. Sorry about the delayed follow up here, I didn't take a look at the original PR until after it landed.

This PR makes some adjustments to those changes and cleans up some nearby/related content.

  • Fix a few analysis errors, for example ...GlobalMaterialLocalizations.delegate was used instead of ...GlobalMaterialLocalizations.delegates.
  • Depend on the used material_ui package.
  • Simplify the no_app_localizations example
  • Use consistent nesting for content of list items.
  • Use SDK package descriptors instead of the deprecated --sdk flag for adding the dependency on flutter_localizations.
  • Highlight relevant lines of code snippets.
  • Add titles to code blocks where helpful.
  • Use contractions where appropriate to match our writing guidelines.
  • Use imperative headings.
  • Some other small wording adjustments.

Staged: https://flutter-docs-prod--docs-pr13710-misc-i18n-decoupling-c-3zvcx58m.web.app/ui/internationalization

@parlough
parlough requested a review from justinmc August 11, 2026 23:15
@parlough
parlough requested review from a team and sfshaza2 as code owners August 11, 2026 23:15
gemini-code-assist[bot]

This comment was marked as outdated.

@flutter-website-bot

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit 932ea0f):

https://flutter-docs-prod--docs-pr13710-misc-i18n-decoupling-c-3zvcx58m.web.app

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Thanks for following up with this!

Comment thread examples/internationalization/gen_l10n_example/lib/main.dart
@flutter-website-bot

Copy link
Copy Markdown
Collaborator

Staged preview of the updated flutter.dev site (updated for commit 932ea0f):

https://flutter-dev-230821--www-pr13710-misc-i18n-decoupling-c-phfm6wo5.web.app

@parlough
parlough requested a review from jesskuras August 11, 2026 23:55

@lamek lamek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parlough
parlough merged commit d195e4e into main Aug 12, 2026
16 checks passed
@parlough
parlough deleted the misc/i18n-decoupling-cleanup branch August 12, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants