Consistently use jaspr_cli managed build options - #13854
Merged
Merged
Conversation
parlough
requested review from
a team,
abdallahshaban557 and
sfshaza2
as code owners
September 2, 2026 22:48
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
4 tasks
Collaborator
|
Staged preview of the updated docs.flutter.dev site (updated for commit e545f56): https://flutter-docs-prod--docs-pr13854-feat-use-jaspr-managed-ooyzw29c.web.app |
Collaborator
|
Staged preview of the updated flutter.dev site (updated for commit e545f56): https://flutter-dev-230821--www-pr13854-feat-use-jaspr-managed-lkygyagg.web.app |
jesskuras
approved these changes
Sep 3, 2026
jesskuras
left a comment
jesskuras
left a comment
Contributor
There was a problem hiding this comment.
Awesome, thanks for looking into this!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--no-managed-build-optionswe were passing to thejaspr buildcommand was meaning--dart-definewasn't respected soproductionBuildwas false for client-compiled code. We don't use thebuild.yamlfiles for much special configuration anyway, so we can instead use Jaspr's managed build options, passing what little we do need to configure. With that change,productionBuildis correctly set totrueon release client build. This fixes code such as analytics sending that was incorrectly being stripped.Supersedes and closes #13851