fix: return finalizer readiness errors#1939
Merged
Merged
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1939 +/- ##
==========================================
- Coverage 30.00% 29.99% -0.01%
==========================================
Files 288 288
Lines 18455 18614 +159
==========================================
+ Hits 5537 5584 +47
- Misses 12189 12295 +106
- Partials 729 735 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aryan9600
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1550, #1562
retry.OnError(...)was already used in the finalizer readiness check, but the returned error got dropped. If the target Deployment hitsProgressDeadlineExceeded, finalization still keeps going anyway, kinda rough.This stores that error and stops finalization until the target is ready. Added a regression test for the stuck Deployment case.
Repro
revertOnDeletion: true.Progressing=FalseandReason=ProgressDeadlineExceeded.main,finalize()returnsniland finalization completes.canary not ready during finalizingand retries later.Tested with
go test ./....