Add a fallback to the slack notification provider - #1322
Conversation
687e0b4 to
0ffa32f
Compare
|
@hloeung Nice one! Can you please test this e2e and print a screenshot from a mobile notification? |
|
We're currently using |
|
Sure, I checked out your branch, rebased with upstream main and pushed so I could trigger this: https://github.com/fluxcd/notification-controller/actions/runs/27192646039/job/80276362068 Keep an eye on the |
|
Thanks for that. Using I'm using a Mattermost to IRC bridge (https://github.com/42wim/matterircd) and added some additional logging. With logging, I can confirm the presence of As well as an earlier applied successfully message: Messages shown via the Mattermost UI is unchanged, as expected. |
matheuscscp
left a comment
There was a problem hiding this comment.
LGTM! 🚀
Just one nit. Please fix, rebase with upstream main and force-push 🙏
Signed-off-by: Haw Loeung <haw.loeung@canonical.com>
0ffa32f to
13b0249
Compare
|
Done! Thanks @matheuscscp, much appreciated. |
This PR adds a short "fallback" message consisting of the components which is used to form the
AuthorNameas well as the first line ofevent.Messagewhich is used as theText.Slack documentation says that the
fallbacktext is used in clients that don't show formatted text (e.g. mobile notifications). Keeping it to use the first line ofevent.Messageshould keep it short enough for mobile notifications and such..In Mattermost,
fallbackis actually a requirement, see Mattermost Message Attachment options. Various deployments are using the Slack notification provider for Mattermost notifications - we're one of them.