auth/gcp: add support for sovereign cloud artifact registry#1201
Merged
Conversation
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
Member
|
Successfully created backport PR for |
This was referenced May 19, 2026
|
Hello Matheus, I should have been more specific. Container images on s3ns are formatted this way : Contrary to gcp, there is no prefix with the location. "u-france-east1" doesn't show up on image name. i think regexp should be change to: const registryPattern = `^(((.+\.)?gcr\.io)|(.+-docker\.pkg\.dev)|(docker\.s3nsregistry\.fr))$`I'm sorry I believe this change affect unit tests too. Thank you in advance! |
Member
Author
|
@zodd3131 These docs disagree with you: https://documentation.s3ns.fr/artifact-registry/docs/docker/troubleshoot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: fluxcd/flux2#5874
This will unblock support only for controller-level workload identity. The Google libraries will read the environment variables internally when using controller-level workload identity. For object-level we will need new API surface, to be covered in a new RFC I'm working on.