Skip to content

auth/gcp: add support for sovereign cloud artifact registry #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matheuscscp merged 1 commit into from
May 19, 2026
+21 −1
Merged

auth/gcp: add support for sovereign cloud artifact registry #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion auth/gcp/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ func (Provider) GetAccessTokenOptionsForArtifactRepository(string) ([]auth.Optio
return nil, nil
}

const registryPattern = `^(((.+\.)?gcr\.io)|(.+-docker\.pkg\.dev))$`
const registryPattern = `^(((.+\.)?gcr\.io)|(.+-docker\.pkg\.dev)|(.+-docker\.s3nsregistry\.fr))$`

var registryRegex = regexp.MustCompile(registryPattern)

Expand Down
20 changes: 20 additions & 0 deletions auth/gcp/provider_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,26 @@ func TestProvider_ParseArtifactRegistry(t *testing.T) {
artifactRepository: "012345678901.dkr.ecr.us-east-1.amazonaws.com",
expectValid: false,
},
{
artifactRepository: "u-france-east1-docker.s3nsregistry.fr/s3ns/dsna-shared-registry-0/shared-registry",
expectValid: true,
},
{
artifactRepository: "u-france-east1-docker.s3nsregistry.fr",
expectValid: true,
},
{
artifactRepository: "docker.s3nsregistry.fr",
expectValid: false,
},
{
artifactRepository: "-docker.s3nsregistry.fr",
expectValid: false,
},
{
artifactRepository: "a.docker.s3nsregistry.fr",
expectValid: false,
},
} {
t.Run(tt.artifactRepository, func(t *testing.T) {
g := NewWithT(t)
Expand Down
Loading